Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(abc:reuse-tab): support custom cache data #1609

Merged
merged 6 commits into from
Jul 16, 2023
Merged

feat(abc:reuse-tab): support custom cache data #1609

merged 6 commits into from
Jul 16, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jul 15, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Jul 15, 2023 •
edited
Loading

Preview is ready!

@codecov
Copy link

codecov bot commented Jul 15, 2023 •
edited
Loading

Codecov Report

Merging #1609 (8a2968c) into master (3cd73f7) will increase coverage by 0.02%.
The diff coverage is 97.56%.

❗ Current head 8a2968c differs from pull request most recent head bcaccaa. Consider uploading reports for the commit bcaccaa to get more accurate results

@@            Coverage Diff             @@
##           master    #1609      +/-   ##
==========================================
+ Coverage   95.49%   95.51%   +0.02%     
==========================================
  Files         276      277       +1     
  Lines        8517     8522       +5     
  Branches     1666     1667       +1     
==========================================
+ Hits         8133     8140       +7     
+ Misses        318      317       -1     
+ Partials       66       65       -1
Impacted Files Coverage Δ
packages/abc/reuse-tab/reuse-tab.service.ts 98.86% <97.14%> (-0.01%) ⬇️
packages/abc/reuse-tab/reuse-tab.cache.ts 100.00% <100.00%> (ø)
packages/abc/reuse-tab/reuse-tab.module.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@cipchk cipchk merged commit 11599d9 into master Jul 16, 2023
@cipchk cipchk deleted the issues-2400 branch July 16, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cipchk @ng-alain-bot